Florian Nagel

Results 39 comments of Florian Nagel

I'll go over the diff later this week to try and catch easy mistakes I made. I don't mind if you do a proofread in the meantime, just be aware...

> Looks like this is something impossible? expected needs a string literal, and i18n is a runtime ting, so I think we can remove it. In theory we could implement...

Another note: I'd like to add issues to open todo-items in hopes of better tracking them. Ie. the following code: ``` // TODO: i18n of clap currently not easily possible....

And one last thing regarding `/src/steps/git.rs`: I don't think there is a good way to deal with the colors and internationalization tbh :thinking: As the resulting objects are not Strings...

> Emmm, putting the whole configuration file as a translation unit does not seem good. When we have multi-language support, this file will be duplicated many time, and there is...

Example for the config translation stuff: ```rs use rust_i18n::t; pub fn construct_default_config() -> String { t!("include").to_string() + r#" [include] # paths = ["/etc/topgrade.toml"] [misc] "# + t!("pre_sudo").as_ref() + "# pre_sudo...

Tracking issue that I will be editing while finishing this PR: https://github.com/topgrade-rs/topgrade/issues/859

I think the PR is pretty much ready to be reviewed. I'm gonna do the rebase for the `Cargo.lock` mismatch and that should be it tbh EDIT: Getting the system...

@SteveLauC Hey there! 👋 I'm currently on vacation. I'll try to look at this again over the next few days, but it's unlikely. I don't mind you doing some work...

> > * [ ] Cleanup and sort the app.yml to remove duplicated or unneeded keys > > This should be done by the locale file checker, I will implement...