woocommerce-simplify-payment-gateway-plugin icon indicating copy to clipboard operation
woocommerce-simplify-payment-gateway-plugin copied to clipboard

Warnings throwing on WC_Gateway_Simplify_Commerce_Loader::__wakeup().

Open mtsiakiris opened this issue 4 years ago • 1 comments

Endless warning messages show up in error log file while running on PHP 8.

The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in ../wp-content/plugins/woocommerce-simplify-payment-gateway-plugin-2.2.0/woocommerce-simplify-payment-gateway.php on line 71.

Warnings goes away when set to public. Please check this, as in cases of high traffic, error logs is on fire. Although this is a minor lets say warning, it doesn't mean nobody has to deal with this, right?

mtsiakiris avatar May 29 '21 16:05 mtsiakiris

PHP 7.4 has now reached end of life support and PHP 8.0 is now the minimum supported release - please merge 2.3.2 with this commit to fix error for public visibility. There are also some other errors when using PHP 8.0 not addressed yet:

Warning: The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in /home/.../public_html/wp-content/plugins/simplifycommerce/woocommerce-simplify-payment-gateway.php on line 72

Deprecated: Required parameter $args follows optional parameter $authentication in /home/.../public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268

Deprecated: Required parameter $expectedArgCount follows optional parameter $authentication in /home/.../public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268

Bartosz-AU avatar Dec 15 '22 08:12 Bartosz-AU