server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-35635: START SLAVE UNTIL allows CHANGE MASTER TO options

Open MohanadKh03 opened this issue 7 months ago • 1 comments
trafficstars

  • [x] *The Jira issue number for this PR is: MDEV-35635

Description

This commit separates master's options from slave options in sql_yacc.yy by replacing master_file_def with slave_until_file_def which only contain the options needed in the query:

START SLAVE UNTIL

These are the only options valid in this query MASTER_LOG_FILE_SYM, MASTER_LOG_POS_SYM, RELAY_LOG_FILE_SYM and RELAY_LOG_POS_SYM and MASTER_GTID_POS

This is only a change in the symbols the START SLAVE command did not use any functionalty related to what was included in master_file_def

Release Notes

How can this PR be tested?

This can be tested using start_slave_until.test file which should test valid options queries and invalid ones Invalid being anything that is not part of this MASTER_LOG_FILE_SYM, MASTER_LOG_POS_SYM, RELAY_LOG_FILE_SYM and RELAY_LOG_POS_SYM and MASTER_GTID_POS

Basing the PR against the correct MariaDB version

  • [x] This is a new feature or a refactoring, and the PR is based against the main branch.
  • [ ] This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

MohanadKh03 avatar Mar 21 '25 14:03 MohanadKh03

To report on the status of this ticket, the work has been reviewed and accepted, and is waiting to be QA tested as part of the 12.1 sprint, which is planned to start on June 3.

bnestere avatar Apr 22 '25 18:04 bnestere