server
server copied to clipboard
MDEV-35948: Test OG `replicate_*`s with long lists
trafficstars
- [x] The Jira issue number for this PR is: MDEV-35948
- Spiritually a prerequisite of #3772 (MDEV-35693)
Description
Assert that 1st-gen replicate_* filter variables display their input – including long but reasonable lists – correctly (without truncation) in
- direct SELECT
- [semi-new] INFORMATION_SCHEMA.GLOBAL_VARIABLES.VARIABLE_VALUE
- [new] SHOW REPLICA STATUS
This tests the fields affected by MDEV-35693 (an 11.6 oversignt).
Also test the input DEFAULT as part of this edge-case testing.
Release Notes
N/A – This is a dev task.
How can this PR be tested?
run the modified files
Basing the PR against the correct MariaDB version
- ~~This is a new feature or a refactoring, and the PR is based against the
mainbranch.~~ - [ ] This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.
PR quality check
- [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
- [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.
Amend + Rebase
diff --git a/mysql-test/suite/sys_vars/t/replicate_do_db_basic.test b/mysql-test/suite/sys_vars/t/replicate_do_db_basic.test
index a99429fe9a..4b72d14d6a 100644
--- a/mysql-test/suite/sys_vars/t/replicate_do_db_basic.test
+++ b/mysql-test/suite/sys_vars/t/replicate_do_db_basic.test
@@ -1,7 +1,7 @@
--source include/have_sequence.inc
# have show_slave_status
---source include/have_log_bin.inc
-CHANGE MASTER TO master_host='example.com';
+--source include/not_embedded.inc
+CHANGE MASTER TO master_host='127.0.0.1', master_user='root';
--let $status_items= Replicate_Do_DB
--echo #
@@ -58,5 +58,4 @@ SET @@GLOBAL.replicate_do_db=DEFAULT;
SELECT @@GLOBAL.replicate_do_db;
--echo # Cleanup.
-RESET REPLICA ALL;
SET @@GLOBAL.replicate_do_db = @save_replicate_do_db;
CHANGE MASTER TO is simply required for some reason, even if it’s changing to the same configs.