server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-35022 Fix Overuse of big stackvariables results inside InnoDB & mariabackup

Open Thirunarayanan opened this issue 1 year ago • 1 comments
trafficstars

  • [x] The Jira issue number for this PR is: MDEV-35022

Description

  • This patch removes the PRAGMA_DISABLE_CHECK_STACK_FRAME usage inside innodb, mariabackup and also made the large variable into thread_local storage or use the heap memory

Release Notes

Made big stack variable into thread local storage and make use of heap memory.

How can this PR be tested?

cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS=-Wstack-usage=8192 -DMYSQL_MAINTAINER_MODE && make -j4

Basing the PR against the correct MariaDB version

  • [ ] This is a new feature or a refactoring, and the PR is based against the main branch.
  • [x] This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Thirunarayanan avatar Sep 27 '24 07:09 Thirunarayanan