server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-34489 innodb.innodb_row_lock_time_ms fails

Open vlad-lesin opened this issue 1 year ago • 1 comments

The test fails because 'variable_value' has not the same type as the value which it's compared to. The fix is to use CAST() not only for 'variable_value', but also for 'count_reset' to avoid future failures.

Reviewed by Marko Mäkelä.

  • [x] The Jira issue number for this PR is: MDEV-______

Description

TODO: fill description here

Release Notes

TODO: What should the release notes say about this change? Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.

How can this PR be tested?

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended. Consult the documentation on "Writing good test cases".

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • [ ] This is a new feature or a refactoring, and the PR is based against the latest MariaDB development branch.
  • [ ] This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [ ] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

vlad-lesin avatar Jun 28 '24 13:06 vlad-lesin

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 28 '24 13:06 CLAassistant

This pull request is closed, because another fix was applied: https://github.com/MariaDB/server/pull/3809.

vlad-lesin avatar Feb 28 '25 08:02 vlad-lesin