server
server copied to clipboard
MariaDB
Toi error vote 10.5
- [x] The Jira issue number for this PR is: MDEV-______
Description
Fixes for error voting issues discovered in the field with production users.
Release Notes
This is a fix to error voting protocol making error voting more reliable. E.g. it will fix erroneous voting results when a client changes lc_messages locale.
How can this PR be tested?
MTR tests were added to test for that specific situation.
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
- [ ] This is a new feature and the PR is based against the latest MariaDB development branch.
- [ ] This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.
PR quality check
- [ ] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
- [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.
Hi @ayurchen, I'm just going through and reviewing a few PRs without conversation yet. This looks like a good solution, and thanks for updating the MTR test as well. I'll let others chime in, but it looks good to me.
Thanks, the fixes have been merged with the head revision: https://github.com/MariaDB/server/commit/731a5aba0b6eb465e82a3f243c5daaf735f7313f and https://github.com/MariaDB/server/commit/83196a7b2398ed3caa52a04e09b656828ad64804
