server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-32175 References to buf_page_t::frame may cost some performance

Open dr-m opened this issue 1 year ago • 1 comments
trafficstars

  • [x] The Jira issue number for this PR is: MDEV-32175

Description

This is work in progress, for performance testing. We are reducing the number of accesses to buf_page_t::frame, because there is an idea to remove that data member and to replace it with a member function that would perform some pointer arithmetics.

Based on the outcome, we might want to revert changes that cause additional calls to page_offset() or page_align().

Release Notes

This does not need to be mentioned, because this is a relatively small performance improvement or code cleanup.

How can this PR be tested?

This is a low-level change that is covered by the regression test suite. It should be tested with RQG as well.

A small part of this depends on #3069.

Basing the PR against the correct MariaDB version

  • [ ] This is a new feature and the PR is based against the latest MariaDB development branch.
  • [ ] This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

This is a code cleanup or a performance improvement.

PR quality check

  • [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

dr-m avatar Feb 16 '24 16:02 dr-m

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 16 '24 16:02 CLAassistant