server icon indicating copy to clipboard operation
server copied to clipboard

Fix COLUMNSTORE in Debian CI builds

Open LinuxJedi opened this issue 2 years ago • 6 comments

Debian building tried to implicitly enable ColumnStore, but it needs to be explicitly enabled to work. This should fix the AARCH64 BuildBot builders.

LinuxJedi avatar May 30 '23 10:05 LinuxJedi

Updated patch due to CMAKE_SYSTEM_PROCESSOR being arm64 on Debian 11 BuildBot, not aarch64.

LinuxJedi avatar May 30 '23 12:05 LinuxJedi

The reason why this broke in the first place was that the override that was supposed to enable ColumnStore on BuildBot Debian packaging builds was broken and now works.

This patch fixes a few things, but new BuildBot Debian autobake is still failing. This is due to missing Boost dependencies. I don't recommend reviewing / merging until this is fixed. Alternatively we should remove the BuildBot ColumnStore override in autobake-deb.sh so it is always off for Debian package builds.

LinuxJedi avatar May 30 '23 13:05 LinuxJedi

Based on the changes I see now, the commit message should be:

Add `arm64` to the supported platforms for ColumnStore Debian buils

Debian build tried to implicitly enable ColumnStore on arm64, but for this
to work, the boost/flex dependencies need to be there.

That isn't quite right though. ColumnStore has been supported on ARM64 Debian for a long time. We had a builder that should have been testing it but we found it wasn't working.

The commit message may change before this is merged.

LinuxJedi avatar May 31 '23 06:05 LinuxJedi

Part of the reason columnstore/CMakeLists.txt needed changing is debian/rules -DCMAKE_SYSTEM_PROCESSOR=$(DEB_HOST_ARCH) is a really dumb thing to do. Debian's architecture terms are so non-standard it was bound to be trouble.

grooverdan avatar May 31 '23 07:05 grooverdan

@grooverdan please remember to update https://github.com/MariaDB/buildbot/commit/6e20c378738970314173235c08e3d6c30da87af3 once this is merged. Not sure how we could automate this and trigger an alert, but it would be very good.

fauust avatar Mar 06 '24 13:03 fauust

with #2893, cmake change no longer required.

grooverdan avatar Mar 06 '24 23:03 grooverdan