slideout icon indicating copy to clipboard operation
slideout copied to clipboard

Add passive mode touch events, calms Lighthouse

Open inoas opened this issue 5 years ago • 8 comments

Refs: https://github.com/Mango/slideout/pull/291 https://github.com/Mango/slideout/pull/289 https://github.com/Mango/slideout/pull/267

inoas avatar Apr 10 '20 14:04 inoas

Coverage Status

Coverage remained the same at 69.88% when pulling 90c433d8540e80e69d133ae1f4aa65cfd5cc19db on inoas:patch-1 into 6eb8440ddc7e94194723f86f6580de4d101762a3 on Mango:master.

coveralls avatar Apr 10 '20 14:04 coveralls

I am using npm install --save inoas/slideout#patch-1 until this gets merged.

Edit: Somehow npm/node didnt eat the above thing correctly. This works in package.json "slideout": "git://github.com/inoas/slideout.git#patch-1",

Note: You should use your own fork of my fork to be on the safe side, if you go the same route

inoas avatar Apr 10 '20 14:04 inoas

@pazguille any chance to merge this rather soon?

inoas avatar Apr 10 '20 14:04 inoas

I ran tests, hints, fixed a preexisting CS issue, ran build - now it should be ok.

inoas avatar Apr 10 '20 15:04 inoas

@pazguille Do you still in any way maintain this, at least eventually consider some PRs to merge? That would be so kind.

inoas avatar Apr 13 '20 17:04 inoas

Ping @pazguille - hope!

inoas avatar Apr 20 '20 10:04 inoas

Any news?

htstudios avatar Apr 27 '20 15:04 htstudios

@pazguille gentle ping for review and merge.

paskal avatar Dec 29 '23 22:12 paskal

kinda dead.

inoas avatar May 08 '24 17:05 inoas