typeorm-graphql-loader icon indicating copy to clipboard operation
typeorm-graphql-loader copied to clipboard

Published 20 hours ago • verified publisher icon Mando75

Redundant typeof BaseEntity typing

Open Defus-E opened this issue 3 years ago • 1 comments

I noticed that both GraphQLDatabaseLoader and GraphQLQueryBuilder use generic extending typeof BaseEntity which is incorrect in some cases because Entity might not be extended from BaseEntity. It enables some difficulties to implement correct typing in real use. It seems everything works great if entity isn't extended from BaseEntity, so I think it's redundant typing. Please, fix it.

Defus-E avatar Apr 18 '22 22:04 Defus-E

++

script-sorcerer avatar Apr 20 '22 10:04 script-sorcerer