phpunit-progress icon indicating copy to clipboard operation
phpunit-progress copied to clipboard

compatibility hack for method naming fix from phpunit 3.7.11

Open AubreyHewes opened this issue 12 years ago • 10 comments

@see https://github.com/Maher4Ever/phpunit-progress/issues/1 @cause https://github.com/sebastianbergmann/phpunit/issues/762

AubreyHewes avatar Jan 22 '13 22:01 AubreyHewes

This request should definitely be accepted. It's a pain to have to edit the file manually after installing the guard-phpunit gem.

wadtech avatar Mar 19 '13 16:03 wadtech

@Maher4Ever just ran into the same thing, please merge.

grncdr avatar Mar 20 '13 19:03 grncdr

I installed Laravel-Guard which includes guard-phpunit which in turn depends on this library. The problem was that the notification would always say that the tests failed and I should check the console, however that gave no hint of what the problem was.

Anyhow, it turns out to be this issue which wasn't easy to find, so I believe many users of Laravel-Guard and guard-phpunit would be grateful for a merge!

erikbrannstrom avatar May 02 '13 14:05 erikbrannstrom

@Maher4Ever - Would you be able to review this PR? We have had to fork this repository due to this issue. :crying_cat_face:

sgerrand avatar May 16 '13 08:05 sgerrand

Thanks @AubreyHewes.

@Maher4Ever please accept.

wadtech avatar May 20 '13 18:05 wadtech

@Maher4Ever: I can confirm that this works across multiple PHPUnit versions. Please accept @AubreyHewes' changeset. :wave:

sgerrand avatar Aug 01 '13 05:08 sgerrand

It doesn't seem like @Maher4Ever is going to be fixing this issue... does anyone know what process needs to happen in order to bypass this issue without having to make manual patches every time this gem is installed?

elliotfleming avatar Aug 27 '13 04:08 elliotfleming

+1 needs to be merged !

nifr avatar Sep 17 '13 13:09 nifr

+1 too

sergigp avatar Sep 29 '13 16:09 sergigp

:+1: I'd like to see this (or an alternative solution) merged in.

gevans avatar Nov 27 '13 09:11 gevans