phpunit-progress
phpunit-progress copied to clipboard
compatibility hack for method naming fix from phpunit 3.7.11
@see https://github.com/Maher4Ever/phpunit-progress/issues/1 @cause https://github.com/sebastianbergmann/phpunit/issues/762
This request should definitely be accepted. It's a pain to have to edit the file manually after installing the guard-phpunit gem.
@Maher4Ever just ran into the same thing, please merge.
I installed Laravel-Guard which includes guard-phpunit which in turn depends on this library. The problem was that the notification would always say that the tests failed and I should check the console, however that gave no hint of what the problem was.
Anyhow, it turns out to be this issue which wasn't easy to find, so I believe many users of Laravel-Guard and guard-phpunit would be grateful for a merge!
@Maher4Ever - Would you be able to review this PR? We have had to fork this repository due to this issue. :crying_cat_face:
Thanks @AubreyHewes.
@Maher4Ever please accept.
@Maher4Ever: I can confirm that this works across multiple PHPUnit versions. Please accept @AubreyHewes' changeset. :wave:
It doesn't seem like @Maher4Ever is going to be fixing this issue... does anyone know what process needs to happen in order to bypass this issue without having to make manual patches every time this gem is installed?
+1 needs to be merged !
+1 too
:+1: I'd like to see this (or an alternative solution) merged in.