uvloop icon indicating copy to clipboard operation
uvloop copied to clipboard

Add test for preexec_fn fd double close issue

Open fantix opened this issue 3 years ago • 3 comments

Refs #466

fantix avatar Jul 17 '22 15:07 fantix

@graingert may I ask for a review pls?

fantix avatar Jul 17 '22 15:07 fantix

@graingert may I ask for a review pls?

Just doing a eyeball pass at the moment - will do a proper review later. My gut feeling is that I think it's a bit complicated using a thread pool executor and a queue and a pipe and an event so I'll see if I can have a ponder on making this simpler - eg just using threading.Barrier

graingert avatar Jul 17 '22 15:07 graingert

@graingert may I ask for a review pls?

Just doing a eyeball pass at the moment - will do a proper review later. My gut feeling is that I think it's a bit complicated using a thread pool executor and a queue and a pipe and an event so I'll see if I can have a ponder on making this simpler - eg just using threading.Barrier

ok I think I've managed to simplify this a lot: https://github.com/MagicStack/uvloop/pull/481/files#r924838769

graingert avatar Jul 19 '22 18:07 graingert

Close in favor of #481

fantix avatar Sep 02 '22 16:09 fantix