Windows version fails with Samsung images

[EddyParkinsonAllTraders]

It is failing with Samsung images on windows.

The work around is force it to use heif-converter-windows.exe

e.g. Maestroerror\HeicToJpg::convert(DIR . '/tests/Unit/images/samsung-generated.heic", DIR . '/bin/heif-converter/bin/heif-converter-windows.exe' )->get();

install libheif on windows

The above requires libheif

run https://github.com/MaestroError/heif-converter-image/blob/maestro/install-libheif-windows.bat

then run .\vcpkg.exe install

then manually set PATH & PKG_CONFIG_PATH see https://github.com/MaestroError/heif-converter-image/blob/maestro/install-libheif-windows.bat

-- install-libheif-windows.bat looks outdated - but it has the right steps

[MaestroError]

@EddyParkinsonAllTraders Hello! I didn't understand what is your issue, but if install-libheif-windows.bat looks outdated, I will be glad to receive your PR for updating ❤️

[EddyParkinsonAllTraders]

This issue is connected to https://github.com/MaestroError/heif-converter-image

The code windows code uses heif-converter-windows rather than heif-converter-windows.exe - swapping these round makes it work.

i.e. this folder https://github.com/MaestroError/heif-converter-image/tree/maestro/bin has heif-converter-windows and heif-converter-windows.exe
but it fails when it uses heif-converter-windows - if I make it use heif-converter-windows.exe then it works.

The 2nd issue - installing libheif I tried to use install-libheif-windows.bat

it needed ".\vcpkg install" rather than ".\vcpkg install libheif"

I also used powershell - I think that cause the setx PATH & PKG_CONFIG_PATH to fail - as the %cd% didn't work.

[MaestroError]

@EddyParkinsonAllTraders Thanks for the information, I will work to update it later.

If you will have some free time any contributions are welcome 👍