Interest in Docker image and associated CI?

[matthewfeickert]

trafficstars

Feature details

:wave: Hi and welcome to GitHub MadAnalysis 5 team! :rocket:

I was wondering if you had any interest in having a Dockerfile for your project that would build a minimal "base" Docker image for others to build upon. This type of Docker image is useful to have in CI as well for both testing the build and then running tests against the build (c.f. https://github.com/scailfin/MadGraph5_aMC-NLO for an example of what I mean).

If so, I have one I wrote quickly on my fork and an associated CI workflow that builds and runs a very simple example as a test. If this is of any interest I'm happy to contribute a PR where we can refine this to your liking.

Implementation

Yes. I already have this done on my fork https://github.com/matthewfeickert/madanalysis5. If you want to see what it would look like roughly before code review for a PR I'd open just pull down the Docker image I made in CI and have on my fork's GitHub Container Registry

docker pull ghcr.io/matthewfeickert/madanalysis5:v1.9.60

and if you want to see it run the differential cross-section plot example from http://madanalysis.irmp.ucl.ac.be/wiki/FAQNormalMode as a sanity check

docker run --rm ghcr.io/matthewfeickert/madanalysis5:v1.9.60 'ma5 --version && cat $(find /root/ -iname "differential_xsec_plot.ma5") | ma5'

and then check inside of the differential_xsec_example it spits out.

How important would you say this feature is?

1: Not important. Would be nice to have.

Additional information

No response

[jackaraz]

Hi @matthewfeickert , thanks a lot that would be great actually. We are still setting up finishing touches for the mitigation from Launchpad but docker is definitely on the cards please do send a PR and we will check it out asap!

[matthewfeickert]

thanks a lot that would be great actually. We are still setting up finishing touches for the mitigation from Launchpad but docker is definitely on the cards please do send a PR and we will check it out asap!

Great! I got a bit swamped today but I'll sync my fork and rebase and clean up my feature branch tomorrow and then PR. :+1: