sage-acf-wp-blocks icon indicating copy to clipboard operation
sage-acf-wp-blocks copied to clipboard

fix for notice on $block['className']

Open ArnoSchneider opened this issue 6 years ago • 5 comments

This should fix the notice on the undefined $block['className']

` if(!empty($block['className'])): $class_name = $block['className'] . ','; else: $class_name = false; endif;

$block['classes'] = implode(' ', [$block['slug'], $class_name . 'align'.$block['align']]);

`

ArnoSchneider avatar May 10 '19 14:05 ArnoSchneider

@MWDelaney would you mind releasing a new release to Packagist?

mcnamee avatar Jul 31 '19 04:07 mcnamee

@mcnamee I did, feel free to use it if needed.

https://github.com/orditeck/sage9-acf-wp-blocks

orditeck avatar Jul 31 '19 15:07 orditeck

Second line: $class_name = $block['className'] . ',';

should be: $class_name = $block['className'] . ' ';

This comma is joining added additional classes. Space is working better ;)

realcgslav avatar Jul 31 '19 19:07 realcgslav

@MWDelaney would you mind releasing a new release to Packagist?

I plan to do this soon once I thoroughly test the newly merged PRs from today. In the meantime, if you set your composer version requirement to dev-master rather than a particular version number you'll get the latest master branch.

MWDelaney avatar Aug 18 '19 14:08 MWDelaney

Any news here?

lachieh avatar Oct 21 '19 16:10 lachieh