modflow6 icon indicating copy to clipboard operation
modflow6 copied to clipboard

feat(prp): support coordinate transformations

Open wpbonelli opened this issue 1 year ago • 2 comments

PRT requires particle release points (except for z via LOCAL_Z) specified in the model coordinate system, and also reports pathlines in the model coordinate system. This PR enables input coordinate transformations with keyword options for the particle release point package.

With this change, points may be specified as

  • model coordinates (default, as before)
  • local cell coordinates scaled to the unit interval with LOCAL_XY and/or LOCAL_Z — only structured grids
  • offsets from the cell center, no rescaling, via LOCAL_XY_OFFSET — structured or unstructured grids
  • global coordinates via dev option DEV_GLOBAL_XY — transform release points to model coordinates using grid georeference information

Checklist of items for pull request

  • [x] Added new test or modified an existing test
  • [x] Formatted new and modified Fortran source files with fprettify
  • [x] Added doxygen comments to new and modified procedures
  • [x] Updated definition files
  • [x] Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • [x] Updated input and output guide
  • [x] Removed checklist items not relevant to this pull request

wpbonelli avatar Jun 26 '24 02:06 wpbonelli

@langevin-usgs this is generally according to our outline ~~with the main difference being MODEL_XY and conditioning the release point transform on grid offset/rotation, probably good to chat again~~ switched to DEV_GLOBAL_XY as discussed offline and updated description above.

wpbonelli avatar Jun 26 '24 02:06 wpbonelli

This should be ready for a look when @aprovost-usgs is back

wpbonelli avatar Jun 28 '24 12:06 wpbonelli