eicu-code icon indicating copy to clipboard operation
eicu-code copied to clipboard

Concept for Vasopressor Durations

Open ajb5d opened this issue 5 years ago • 4 comments

I'd like to contribute a materialized view for vasopressor durations (similar to the MIMIC tables). What is the preferred 'dialect' of SQL? BigQuery or Postgres? The syntax for casting is different between the two.

ajb5d avatar Feb 14 '20 21:02 ajb5d

@ajb5d Thanks for the message, and good question! Either/both would be appreciated. We're using BigQuery a lot at the moment, especially at datathons, so a BigQuery version would definitely get some use.

We don't have a good system for managing different dialects of SQL, so we'd welcome your suggestions for this. With MIMIC we have ended up with two separate branches (google-cloud-views for BigQuery and master for Postgres), which isn't ideal.

tompollard avatar Feb 15 '20 02:02 tompollard

Would it be reasonable make a directory for each dialect and keep them on the same branch?

Also, Are you opposed to a Postgres user-defined function? I'm having trouble finding an elegant way to cast a string to integer in a "safe" way.

ajb5d avatar Feb 15 '20 20:02 ajb5d

Would it be reasonable make a directory for each dialect and keep them on the same branch?

I think this probably easier to navigate than separate branches, so sounds good to me.

Also, Are you opposed to a Postgres user-defined function? I'm having trouble finding an elegant way to cast a string to integer in a "safe" way.

Also sounds good to me!

tompollard avatar Feb 19 '20 00:02 tompollard

Sorry I haven't reviewed the PR yet, but hopefully I will find time to soon!

alistairewj avatar Aug 21 '20 14:08 alistairewj