revolution-irc
revolution-irc copied to clipboard
MCMrARM
Show notices in the channel
It seems channel notices are currently treated as queries, showing up as a separate tab in the channel switcher. I think private notices do the same. I'm not sure if that is how it's meant to be.
How WeeChat handles this is checking if the NOTICE begins with [#channel] and if it does, it sends the NOTICE to the #notice buffer. This syntax is used by at least Atheme IRC Services (used e.g. on freenode).
Flagging this as 'enhancement' as this is about parsing specific messages rather than a bug in the client.
Not sure about the timetable for this one. I'd need to collect some examples.
As @mcmrarm noted in #100, there are security implications to allowing anyone to send what looks like a channel message, when they may not even be part of the channel.
Potential solutions include:
- a fixed whitelist of the *SERV bots
- checking against the membership of the channel, though I suspect that would be problematic because there's a delay after joining before the membership list is collected, during which such messages would be undecidable, and because it would also require checking the "voiced" status of the sender if the channel is restricted.
Maybe do a host whitelist instead? I think all services have a rather distinctive hostname (like services.*?).
Hmm, the delay is something I definitely missed and is something which would require a bit of consideration. I don't think the channel modes are sent w/o asking for them either. So this could be delayed or perhaps another solution can be found. As for the whitelist, it'd be ok, but I think it could be used in addition to some other sane heuristics which would pass most messages that should pass but not too many.
Also perhaps I'm overthinking this. A 'only you can see this' header might be enough for this, with this only being a way to bypass channel flags - perhaps add a way to ignore these messages for notifications. However, it might cause a confusion among people new to IRC, and one of my goals with this application is to make IRC available and modern, so I think I'd prefer to avoid this.