Predicting_real_estate_prices_using_scikit-learn icon indicating copy to clipboard operation
Predicting_real_estate_prices_using_scikit-learn copied to clipboard

Published 20 hours ago • verified publisher icon MBKraus

CMake enable exports by default

Open HBelusca opened this issue 3 years ago • 4 comments

Purpose

"Recent" CMake versions do not allow EXECUTABLE targets to export symbols (only libraries), unless the ENABLE_EXPORTS property is enabled by-target. I argue that this is unnatural, because the original behaviour (allowing EXE targets to export symbols) is what is natural for PE binaries on Windows/NT-like platforms.

Therefore, I globally enable ENABLE_EXPORTS to be set (ON, or TRUE), by setting the global CMAKE_ENABLE_EXPORTS variable, only when build-configuring the main targets (not the host-tools).

Related JIRA issue: CORE-15406 See also PR #1335 and #808, as well as commit 957e566.

Proposed changes

[CMAKE] Globally enable executables (not only libraries) to be able to export symbols...

... following the ENABLE_EXPORTS CMake "débâcle", partly-fixed originally
by commit d8e92b5 (see PR #1335), and finally by commit 957e566.

[APITESTS][FREELDR][NTVDM][SPOOLSV] Remove now-unneeded ENABLE_EXPORTS property.

HBelusca avatar Dec 04 '21 01:12 HBelusca