Predicting_real_estate_prices_using_scikit-learn icon indicating copy to clipboard operation
Predicting_real_estate_prices_using_scikit-learn copied to clipboard

Published 20 hours ago • verified publisher icon MBKraus

[KMTESTS:IO] Rewrite IoDeviceInterface kmtest CORE-17361

Open oleg-dubinskiy opened this issue 4 years ago • 5 comments

Purpose

Add new kernel-mode test for device interface functions, based on the patch by Mark Jansen. The previous one was buggy and crashed even on Windows. The new one doesn't fail, and works without bugs. Although there is missing one test case (for IoRegisterDeviceInterface). Also perhaps IoRegister/UnregisterPlugPlayNotification testcase should be kept, if it's also corresponding to device interface functions. This kmtest helped me to test the behaviour of some IoDeviceInterface* routines (and understand a bit more how they're functioning), whose I already improved in my previous PRs: #3510, #3583 and #3584.

JIRA issue: CORE-17361

Proposed changes

Add a new kmtest with testcases for:

  • IoGetDeviceInterfaceAlias.
  • IoGetDeviceInterfaces.
  • IoOpenDeviceInterfaceRegistryKey.
  • IoSetDeviceInterfaceState.

TODO

  • [x] Maybe restore IoRegister/UnregisterPlugPlayNotification testcase if it also corresponds to device interface functions.
  • [ ] Maybe add the IoRegisterDeviceInterface testcase, but I seem to have not enough skills for that (since that function works with device objects and other stuff like that, not only with registry and symbolic links).

Result

The test in its current state completely succeeds on Windows XP and 2003. :slightly_smiling_face:

kmtest_XP

oleg-dubinskiy avatar Apr 08 '21 19:04 oleg-dubinskiy