NanaZip icon indicating copy to clipboard operation
NanaZip copied to clipboard

Option to disable Dark Mode

Open Dantasstic opened this issue 1 year ago • 24 comments

I don't like the look of Dark Mode for NanaZip, so I would like the ability to toggle it off. Can this be added?

EDIT: I know it follows the system settings. I don't want my entire system in light mode, I want this particular app in light mode. Other apps have toggles to follow the system settings or select light or dark, and that is what I would like to see for NanaZip as well.

Dantasstic avatar Jun 06 '24 12:06 Dantasstic

put your system in light mode

DevX-Cipher avatar Jun 06 '24 12:06 DevX-Cipher

but yer the background color is too dark and should 255,45,45

DevX-Cipher avatar Jun 06 '24 13:06 DevX-Cipher

I don't want my entire system in light mode, I want this particular app in light mode. Tons of other apps have toggles to follow the system settings or select light or dark. This is pretty standard.

Dantasstic avatar Jun 06 '24 13:06 Dantasstic

yes i know i will try and push something for it

DevX-Cipher avatar Jun 06 '24 13:06 DevX-Cipher

the project is all over the place now will take me some time to understand it all again

DevX-Cipher avatar Jun 06 '24 13:06 DevX-Cipher

yes i know i will try and push something for it

That would be lovely :)

Dantasstic avatar Jun 06 '24 13:06 Dantasstic

yes i know i will try and push something for it

I don't want dark mode in this software either. I can't see any %APPDATA% files for NanaZip, so please give information on which registry key the setting uses so I can automatically add it in setup scripts.

eggbean avatar Jun 16 '24 22:06 eggbean

I would love this too!!

VermillionFury007 avatar Jun 18 '24 20:06 VermillionFury007

adding my overwhelming support for this feature.

Kinda ironic that this feature is useless for me in 95% of apps but when I actually could use it, it doesn't exist 😂

notNSANE avatar Sep 28 '24 14:09 notNSANE

Plus one :-)

Hermholtz avatar Nov 29 '24 11:11 Hermholtz

yeah, why the fuk there is no toggle for white mode.... who asked this dark mode?

KristoferYG avatar Jan 07 '25 12:01 KristoferYG

yeah, why the fuk there is no toggle for white mode.... who asked this dark mode?

Sadly, it doesn’t seem like any change will be happening. I’ve gone back to 7-Zip for the time being. :/

Dantasstic avatar Jan 07 '25 12:01 Dantasstic

the annoying thing is you have to build the project without Visual Studio just to test it which is so annoying

DevX-Cipher avatar Jan 12 '25 11:01 DevX-Cipher

I've added a checkbox under the settings for now, but I still need to do more testing. This is because NanaZip's dark mode isn't applied dynamically while the application is running.

DevX-Cipher avatar Feb 02 '25 13:02 DevX-Cipher

@MouriNaruto cant seem to change the darkmode dynamically at runtime also reason why your using dpi

DevX-Cipher avatar Feb 02 '25 14:02 DevX-Cipher

You should see the implementation in https://github.com/M2Team/NanaZip/blob/main/NanaZip.Frieren/NanaZip.Frieren.DarkMode.cpp

Kenji Mouri

MouriNaruto avatar Feb 02 '25 14:02 MouriNaruto

@MouriNaruto this is only happening when the system changes from light to darkmode while the application is running not when the button is checked and unchecked

DevX-Cipher avatar Feb 02 '25 14:02 DevX-Cipher

I've added a checkbox under the settings for now, but I still need to do more testing. This is because NanaZip's dark mode isn't applied dynamically while the application is running.

NanaZip won't accept the dark mode switching unless you change your system's dark/light theme setting or app initializing.

Kenji Mouri

MouriNaruto avatar Feb 02 '25 14:02 MouriNaruto

@MouriNaruto so your wanting the user to go to there system settings all the time to change from light to dark mode

DevX-Cipher avatar Feb 02 '25 14:02 DevX-Cipher

@MouriNaruto this is only happening when the system changes from light to darkmode while the application is running not when the button is checked and unchecked

Because I never consider about the disable switch for that. You need to add some logic for the dark mode engine.

Kenji Mouri

MouriNaruto avatar Feb 02 '25 14:02 MouriNaruto

@MouriNaruto ok i will scrap the idea then but we need to fix the darkmode being so dark but since your using dpi only good when hdr is off which you already know this

DevX-Cipher avatar Feb 02 '25 14:02 DevX-Cipher

@MouriNaruto хорошо, тогда я откажусь от этой идеи, но нам нужно исправить тёмный режим, который слишком тёмный, но поскольку вы используете только разрешение в пикселях, это хорошо только при отключённом HDR, о чём вы уже знаете

so the dark theme wasn't fixed? It's too dark and there are no horizontal dividing lines :( I also wish it was possible to force the light and dark themes to be changed.

PLEASE

k1tc3t avatar Jun 16 '25 14:06 k1tc3t

Is this too hard to implement I wonder... 🤔

minus21grams avatar Jun 17 '25 06:06 minus21grams

@minus21grams i haven't done it sorry because developer didn't want to do it

DevX-Cipher avatar Jun 24 '25 15:06 DevX-Cipher

Still no update on this?

Furshia avatar Aug 18 '25 05:08 Furshia