Lightly icon indicating copy to clipboard operation
Lightly copied to clipboard

Title bar not transparent

Open Rmdhn1 opened this issue 4 years ago • 20 comments

I've added a fourth value to the colour scheme, and the menu and tool bar ARE transparent, but the title bar isn't!

Rmdhn1 avatar Nov 14 '21 01:11 Rmdhn1

Have you restarted kwin?

Luwx avatar Nov 14 '21 03:11 Luwx

how? i've restarted the pc tho, Screenshot_20211114_105200

Rmdhn1 avatar Nov 14 '21 03:11 Rmdhn1

That's really strange. Does it also happen with the Breeze decoration?

Luwx avatar Nov 14 '21 04:11 Luwx

actually, yeah, even with the breeze application style

Rmdhn1 avatar Nov 14 '21 04:11 Rmdhn1

It's because of the new headers. A quick fix is to remove the [Colors:Header] and [Colors:Header][Inactive] sections from the color scheme. You might also need to change activeBackground and inactiveBackground to the backgroundNormal color under [Colors:Window] or the titlebar will be a separate color from the rest of the header.

The header colors override the window titlebar's colors.

doncsugar avatar Nov 14 '21 18:11 doncsugar

Doesn't work?

[ColorEffects:Disabled]
Color=56,56,56
ColorAmount=0
ColorEffect=0
ContrastAmount=0.65
ContrastEffect=1
IntensityAmount=0.1
IntensityEffect=2

[ColorEffects:Inactive]
ChangeSelectionColor=true
Color=112,111,110
ColorAmount=0.025
ColorEffect=2
ContrastAmount=0.1
ContrastEffect=2
Enable=false
IntensityAmount=0
IntensityEffect=0

[Colors:Button]
BackgroundAlternate=66,68,79
BackgroundNormal=48,51,61
DecorationFocus=46,179,152
DecorationHover=46,179,152
ForegroundActive=61,174,233
ForegroundInactive=102,106,115
ForegroundLink=41,128,185
ForegroundNegative=218,68,83
ForegroundNeutral=246,116,0
ForegroundNormal=211,218,227
ForegroundPositive=39,174,96
ForegroundVisited=46,179,152

[Colors:Complementary]
BackgroundAlternate=47,52,63
BackgroundNormal=40,42,51
DecorationFocus=46,179,152
DecorationHover=46,179,152
ForegroundActive=61,174,233
ForegroundInactive=102,106,115
ForegroundLink=41,128,185
ForegroundNegative=218,68,83
ForegroundNeutral=246,116,0
ForegroundNormal=211,218,227
ForegroundPositive=39,174,96
ForegroundVisited=46,179,152

[Colors:Selection]
BackgroundAlternate=29,153,243
BackgroundNormal=21,83,68
DecorationFocus=66,255,214
DecorationHover=66,255,214
ForegroundActive=252,252,252
ForegroundInactive=55,216,208
ForegroundLink=253,188,75
ForegroundNegative=218,68,83
ForegroundNeutral=246,116,0
ForegroundNormal=255,255,255
ForegroundPositive=39,174,96
ForegroundVisited=189,195,199

[Colors:Tooltip]
BackgroundAlternate=47,52,63
BackgroundNormal=40,42,51
DecorationFocus=46,179,152
DecorationHover=46,179,152
ForegroundActive=61,174,233
ForegroundInactive=102,106,115
ForegroundLink=41,128,185
ForegroundNegative=218,68,83
ForegroundNeutral=246,116,0
ForegroundNormal=211,218,227
ForegroundPositive=39,174,96
ForegroundVisited=46,179,152

[Colors:View]
BackgroundAlternate=64,69,82
BackgroundNormal=50,52,61
DecorationFocus=46,179,152
DecorationHover=46,179,152
ForegroundActive=61,174,233
ForegroundInactive=102,106,115
ForegroundLink=41,128,185
ForegroundNegative=218,68,83
ForegroundNeutral=246,116,0
ForegroundNormal=211,218,227
ForegroundPositive=39,174,96
ForegroundVisited=46,179,152

[Colors:Window]
BackgroundAlternate=47,52,63
BackgroundNormal=40,42,51
DecorationFocus=46,179,152
DecorationHover=46,179,152
ForegroundActive=61,174,233
ForegroundInactive=102,106,115
ForegroundLink=41,128,185
ForegroundNegative=218,68,83
ForegroundNeutral=246,116,0
ForegroundNormal=211,218,227
ForegroundPositive=39,174,96
ForegroundVisited=46,179,152

[General]
ColorScheme=QogirManjaroDarkTransparent
Name=QogirManjaroDark1
shadeSortColumn=true

[KDE]
contrast=4

[WM]
activeBackground=40,42,51,208
activeBlend=47,52,63
activeForeground=211,218,227
inactiveBackground=40,42,51,208
inactiveBlend=47,52,63
inactiveForeground=102,106,115

Rmdhn1 avatar Nov 22 '21 00:11 Rmdhn1

It (still) works for me: image

I even pasted your colors directly into a file, but I only see it breaking with color schemes with headers. I am on KDE 5.23.3, Frameworks 5.87.0, Qt 5.15.2.

In any case, @Luwx did you plan on supporting headers? I personally wanted a bit more control over the tinting/shading of the header area—it can look a bit washed out depending on window color.

doncsugar avatar Nov 23 '21 00:11 doncsugar

Also on KDE 5.23.3 and QT 5.15.2, but i'm on frameworks 5.88.0

Rmdhn1 avatar Nov 23 '21 07:11 Rmdhn1

I was playing around with a WhiteSur theme and had the same issue.

The https://github.com/Luwx/Lightly/issues/142#issuecomment-968341466 above from @Rmdhn1 did the trick for me as well. I had to remove the two mentioned sections.

KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2

kimwnasptd avatar Nov 25 '21 23:11 kimwnasptd

hmmm, then my issue seems to be different? as that doesn't seem to fix it, but both of you are on previous Frameworks version

Rmdhn1 avatar Nov 27 '21 15:11 Rmdhn1

@Rmdhn1, I compiled from source on latest neon user edition (Plasma 5.23.3, Frameworks 5.88, Qt 5.15.3) and it is working.

What does the Lightly color scheme look like on a newly opened Dolphin window?

doncsugar avatar Nov 28 '21 21:11 doncsugar

@doncsuga always built from source, colour scheme looked like above screenshot Screenshot_20211129_075744

Rmdhn1 avatar Nov 29 '21 00:11 Rmdhn1

I am on Kubuntu 21.10 and having the same issue (restarted my PC just to be sure).

The #142 (comment) above from @Rmdhn1 did the trick for me as well. I had to remove the two mentioned sections.

Do I have to remove these sections from colors/Lightly.colors in the source directory of the theme? These sections do not exist in that file on my installation (just installed from the master branch). Any ideas?

KDE Plasma Version: 5.23.4
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Graphics Platform: X11

emielmolenaar avatar Dec 23 '21 10:12 emielmolenaar

the way https://github.com/Luwx/Lightly/issues/142#issuecomment-968341466 supplied by @Rmdhn1 still not work on my pc. both with lightly and breeze color scheme. KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 Graphics Platform: X11

PaPerseller avatar Apr 20 '22 03:04 PaPerseller

Same for me.

Akruidenberg avatar Apr 23 '22 17:04 Akruidenberg

I'm beginning to think this problem is more than just Plasma and Frameworks versions. When I switched to Arch, the Disk Usage bar in Dolphin looked correct. #69 shows the broken bar. It may not be a surprise that the titlebar also behaves properly.

For the 2 screenshots, I used the following configuration:

Application Style: Lightly Window Decorations: Lightly Color Scheme: Lightly

image image

Here are my current versions:

Operating System: Arch Linux KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.3 Graphics Platform: X11

Just to be sure, what is everyone's OS? I'll try and test a few distros to see where the problem shows up.

doncsugar avatar Apr 24 '22 16:04 doncsugar

I'm beginning to think this problem is more than just Plasma and Frameworks versions. When I switched to Arch, the Disk Usage bar in Dolphin looked correct. #69 shows the broken bar. It may not be a surprise that the titlebar also behaves properly.

For the 2 screenshots, I used the following configuration:

Application Style: Lightly Window Decorations: Lightly Color Scheme: Lightly

image image

Here are my current versions:

Operating System: Arch Linux KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.3 Graphics Platform: X11

Just to be sure, what is everyone's OS? I'll try and test a few distros to see where the problem shows up.

Operating System: Manjaro KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 Graphics Platform: X11

PaPerseller avatar Apr 24 '22 17:04 PaPerseller

Well this is strange. I tested Lightly with some live USBs and did not have problems with the titlebar, but I know in the past I have run into the issue. Is it fixed now @Luwx ?

Using these settings: Application Style: Lightly Window Decorations: Lightly Color Scheme: Lightly

I tested:

KDE Neon 5.24 KDE Plasma Version: 5.24.3 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.3

  • Titlebar seems to work and is translucent and blurred.
  • KCapacity bar is not styled

Manjaro KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3

  • Both source and prepackaged versions seem to work
  • The source version seems to have the slider/bar background part thinner than its fill part. (e.g. the gray part is thicker than the blue part)

OpenSUSE Tumbleweed KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.2

  • Blur seems to work
  • In the source version, kcapacity bar is broken and the slider's background is thin

doncsugar avatar Apr 28 '22 00:04 doncsugar

This really seems to be a configuration issue, not sure exactly where, but probably not in Lightly part. The thinner slider background is intentional.

Luwx avatar Apr 29 '22 23:04 Luwx

Ha ha, darn, I was not a fan of the thinner slider backgrounds.

I think the titlebar issue may be resolved, at least on newer versions of KDE. I am somewhat worried it is not clear that Lightly consists of both an Application Style and a Window Decoration and people are getting confused.

doncsugar avatar Apr 30 '22 01:04 doncsugar