lua-language-server icon indicating copy to clipboard operation
lua-language-server copied to clipboard

VSCodium installs the MacOS binary on Linux

Open takase1121 opened this issue 3 years ago • 9 comments

Describe the bug I installed the plugin from OpenVSX (via the Extensions sidebar in VSCodium) and it didn't launch. I go into ~/.vscode-oss/extensions/sumneko.lua-3.2.0/server/bin and found that there was an exec format error. I dug deeper and found that the binary is for MacOS (Mach O).

To Reproduce Steps to reproduce the behavior:

  1. Install VSCodium
  2. Open the extensions sidebar
  3. Search for "lua"
  4. Install the extension
  5. Open a lua file

Expected behavior Intellisense works, I can refactor variable names, etc.

Screenshots If applicable, add screenshots to help explain your problem. image image

Environment (please complete the following information):

  • OS: Fedora 36 (XFCE spin), kernel 5.17.11-300.fc36.x86_64
  • Client: VSCodium

takase1121 avatar Jun 04 '22 01:06 takase1121

Please install 2.5.3 See https://github.com/EclipseFdn/open-vsx.org/issues/1045

sumneko avatar Jun 04 '22 11:06 sumneko

Please install 2.5.3 See EclipseFdn/open-vsx.org#1045

Thank you very much!

Just asking, is it possible to not bundle the binaries but instead allow the user to change to a binary somewhere? I always have the binary around for neovim and other LSP clients, so bundling the binary wouldn't matter for me.

takase1121 avatar Jun 04 '22 11:06 takase1121

See https://github.com/sumneko/lua-language-server/wiki/Precompiled-Binaries

sumneko avatar Jun 04 '22 11:06 sumneko

Yes, I have the binary, is there a way to set the path to it in the settings?

takase1121 avatar Jun 04 '22 11:06 takase1121

See https://github.com/sumneko/lua-language-server/wiki/Command-line You can specify binary and script files, such as ./bin/lua-language-server ./sumneko.lua/main.lua

EDIT: If you are using OpenVSX, there is no way, unless providing a special client for it.

sumneko avatar Jun 04 '22 11:06 sumneko

See https://github.com/sumneko/lua-language-server/wiki/Command-line You can specify binary and script files, such as ./bin/lua-language-server ./sumneko.lua/main.lua

EDIT: If you are using OpenVSX, there is no way, unless providing a special client for it.

Sorry, I mean to ask if there's a way to set the path to lua-language-server in VSCode (and VSCodium) in extension settings. image

there is a Misc: Parameters setting but that only allows for setting command line arguments.

Currently my workaround for this issue is to symlink my lua-language-server to ~/.vscode-oss/extensions/(plugin name)/server. I hope that instead of symlinking it, I can simply provide the path to lua-language-server and have the VSCode plugin use that.

takase1121 avatar Jun 05 '22 01:06 takase1121

https://github.com/sumneko/vscode-lua/blob/2db6b9ed6ce17142f33e12bed89f2c4b61178d3b/client/src/languageserver.ts#L90-L99

The path is fixed and there is currently no way to modify it.

sumneko avatar Jun 05 '22 07:06 sumneko

Maybe don't provide a binary, instead, bundle a script that detects the platform and retrieves the binary from GitHub instead.

ShizuhaAki avatar Jun 06 '22 06:06 ShizuhaAki

Maybe don't provide a binary, instead, bundle a script that detects the platform and retrieves the binary from GitHub instead.

You can open a PR for https://github.com/sumneko/vscode-lua

sumneko avatar Jun 06 '22 06:06 sumneko

Issue has gone stale

carsakiller avatar Nov 12 '22 07:11 carsakiller