lottie-react icon indicating copy to clipboard operation
lottie-react copied to clipboard

fix: bail-out from async `createLottie` after unmount

Open Andarist opened this issue 3 years ago • 7 comments

Description

Without this we might end up with a warning in older versions of React:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.

Type of change

  • [x] Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • [x] This is something we need to do.

Andarist avatar Jul 09 '22 14:07 Andarist

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 08 '22 02:09 github-actions[bot]

Bump for stale bot

Andarist avatar Sep 08 '22 05:09 Andarist

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Nov 09 '22 02:11 github-actions[bot]

Bump

Andarist avatar Nov 09 '22 07:11 Andarist

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Jan 10 '23 02:01 github-actions[bot]

Bump

Andarist avatar Jan 10 '23 05:01 Andarist

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Mar 12 '23 02:03 github-actions[bot]