obsidian-folder-notes icon indicating copy to clipboard operation
obsidian-folder-notes copied to clipboard

Tag view collapse icon is misaligned

Open reply2za opened this issue 1 year ago • 11 comments
trafficstars

The collapse icon within the tag view is towards the bottom of the line instead of being centered.

image

Environment Obsidian version: 1.7.3 Obsidian theme: none (default) Folder notes version: 1.7.31 Platform: Windows

reply2za avatar Oct 02 '24 03:10 reply2za

Should be fixed now

LostPaul avatar Oct 03 '24 12:10 LostPaul

Thanks! It looks much better. I'm not sure if I'm pixel peeping here but it seems ever so slightly higher than it should be. Have you considered making it 3px or 3.5px instead of 4?

reply2za avatar Oct 03 '24 21:10 reply2za

Thanks for the quick fix!

This still seems just a bit off to me. I think it might be this style:

.fn-whitespace-stop-collapsing .nav-folder-collapse-indicator {
    margin-top: 4px !important;
}

Here's what the explorer looks like with this style enabled:

Screenshot 2024-10-03 at 9 11 30 PM

And here's what it looks like with it disabled:

Screenshot 2024-10-03 at 9 11 08 PM

LandonSchropp avatar Oct 04 '24 04:10 LandonSchropp

Looks good to me, can you reproduce it in a sandbox vault? What's the theme you're using and Obsidian version? MaxZj3ftFG1vUACxSFJd minUHQmq3z3RM1WxUkXw

LostPaul avatar Oct 05 '24 19:10 LostPaul

@LostPaul Hmm, that's odd.

The theme I was using in my screenshot was Minimal, but I can repro it using the default theme as well. Here's a screenshot:

Screenshot 2024-10-05 at 1 49 22 PM

And here it is was that style disabled:

Screenshot 2024-10-05 at 1 50 23 PM

I'm using Obsidian 1.6.7, which the settings say is the latest version.

LandonSchropp avatar Oct 05 '24 20:10 LandonSchropp

@LostPaul Hmm, that's odd.

The theme I was using in my screenshot was Minimal, but I can repro it using the default theme as well. Here's a screenshot:

Screenshot 2024-10-05 at 1 49 22 PM

And here it is was that style disabled:

Screenshot 2024-10-05 at 1 50 23 PM

I'm using Obsidian 1.6.7, which the settings say is the latest version.

Do you also have the latest plugin version installed?

LostPaul avatar Oct 05 '24 20:10 LostPaul

I think so. I'm running 1.7.32. There aren't any more recent updates from the Community.

Screenshot 2024-10-05 at 2 27 03 PM

LandonSchropp avatar Oct 05 '24 21:10 LandonSchropp

Alright and it still happens when disable all other plugins and restart Obsidian?

LostPaul avatar Oct 05 '24 21:10 LostPaul

@LostPaul Sorry for the delay!

You're right; this doesn't appear to be purely a Folder Notes problem. Instead, it seems to be an issue with Folder Notes + Iconize.

Screenshot 2024-10-12 at 12 23 03 PM

Repro steps:

  1. Create a new empty Obsidian Vault
  2. Turn on community plugins
  3. Install the Folder Notes plugin via Community Plugins and enable it
  4. Install the Iconize plugin and enable it
  5. Create a folder in the Obsidian sidebar
  6. Create a node inside of the folder with a different name than the folder
  7. Hover over the folder so you can clearly see the caret icon against the background.

As you can see from the screenshot, the icon is misaligned. Disabling the style above fixes it.

LandonSchropp avatar Oct 12 '24 19:10 LandonSchropp

This CSS code helped a bit for anyone who might want it:

.tree-item-self .tree-item-icon {
    margin-top: -5px !important;
}

It's technically adjusting the CSS associated with Iconize but puts the folder icons thingies (the collapse/expand things) in the same place as just turning off Iconize entirely (for me).

noprotocolunit avatar Oct 24 '24 20:10 noprotocolunit

I just noticed this as well. Obsidian v1.8.7 (installer 1.8.4). Folder Notes v1.7.35.

  1. Open the Sandbox vault.
  2. Install and enable Folder Notes.
  3. Observe the mis-alignment in the Outline and Tags tabs.

Image

It appears to be coming from this:

fn-whitespace-stop-collapsing .collapse-icon {
    padding-top: 4px !important;
}

commenting that out in styles.css, reloading, and using:

.workspace-leaf-content[data-type="file-explorer"] .tree-item-self .tree-item-icon {
    margin-top: 4px;
}

seems to take care of the alignment issue in Files and the Outline and Tabs icons are unaffected. Don't know if that's the best way, but it's working for me.

trainbuffer avatar Feb 22 '25 01:02 trainbuffer

Can you try out the latest beta to see if everything works alright there? I've removed the css code completely that modified the folders and instead solely used code without touching the css to make the prevention of folders collapsing who have a folder note possible.

LostPaul avatar Jun 16 '25 13:06 LostPaul