react-native-youtube-iframe icon indicating copy to clipboard operation
react-native-youtube-iframe copied to clipboard

feat: add a setHeight method to the player ref to resize it

Open Kloadut opened this issue 4 years ago • 3 comments

I wanted to resize the player on the fly, for example to support vertical videos like https://youtu.be/GeYK9JdPVMw.

I added a new method to the YoutubePlayer ref in order to do that. Let me know if that's a feature you'd be interested in and if there's anything you'd like me to change.

Cheers!

Kloadut avatar Nov 10 '21 11:11 Kloadut

Hey, terribly sorry for the late reply.

This is a good feature to have, but would be better to directly set the height prop on the component.

We'll have to make this https://github.com/LonelyCpp/react-native-youtube-iframe/issues/13#issuecomment-611753123 into a toggleable prop. after enabling this, users can simply change the height and width prop to get the desired effect

LonelyCpp avatar Dec 07 '21 16:12 LonelyCpp

let me know if you wanna work on this, else I'll take it up

LonelyCpp avatar Dec 07 '21 16:12 LonelyCpp

Hola! No worries :)

Work on it if you find time

Kloadut avatar Dec 16 '21 10:12 Kloadut