redux-logger icon indicating copy to clipboard operation
redux-logger copied to clipboard

check the logger for trace and the options for withTrace

Open danReynolds opened this issue 7 years ago • 3 comments

There was an issue with: https://github.com/evgenyrodionov/redux-logger/pull/205

In the PR feedback it was recommended to make a withTrace option for the config, but instead it was used to check the logger object.

What we want to happen is to have a withTrace option checked off the config as well as a trace property checked off of the logger object to make sure it supports trace.

danReynolds avatar Jun 13 '18 19:06 danReynolds

Codecov Report

Merging #304 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #304   +/-   ##
=====================================
  Coverage      82%    82%           
=====================================
  Files           5      5           
  Lines         150    150           
=====================================
  Hits          123    123           
  Misses         27     27
Impacted Files Coverage Δ
src/defaults.js 75% <ø> (ø) :arrow_up:
src/core.js 73.33% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ca9f2c...e3720e2. Read the comment docs.

codecov-io avatar Jun 13 '18 19:06 codecov-io

Can someone review this? it's pretty useful. Perhaps @grushetsky 🙏

Eyesonly88 avatar Oct 03 '18 04:10 Eyesonly88

bump

d4rky-pl avatar Jan 11 '19 09:01 d4rky-pl