redux-logger
redux-logger copied to clipboard
check the logger for trace and the options for withTrace
There was an issue with: https://github.com/evgenyrodionov/redux-logger/pull/205
In the PR feedback it was recommended to make a withTrace option for the config, but instead it was used to check the logger object.
What we want to happen is to have a withTrace option checked off the config as well as a trace property checked off of the logger object to make sure it supports trace.
Codecov Report
Merging #304 into master will not change coverage. The diff coverage is
100%.
@@ Coverage Diff @@
## master #304 +/- ##
=====================================
Coverage 82% 82%
=====================================
Files 5 5
Lines 150 150
=====================================
Hits 123 123
Misses 27 27
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/defaults.js | 75% <ø> (ø) |
:arrow_up: |
| src/core.js | 73.33% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3ca9f2c...e3720e2. Read the comment docs.
Can someone review this? it's pretty useful. Perhaps @grushetsky 🙏
bump