fast-langdetect icon indicating copy to clipboard operation
fast-langdetect copied to clipboard

Some feedback

Open SeanPedersen opened this issue 6 months ago • 1 comments

Hey, nice and useful project. While using it I noticed some minor annoyances though:

  • no obvious documentation that map the language abrevations to the language name in english (only found a hidden list in https://fasttext.cc/docs/en/language-identification.html)
  • very verbose warnings that should be turned off or mitigated (verbose=False should be default IMO)
  • Warning: too long string is bad -> why is the default not a cutoff at length 80 or whatever is best?
  • Warning: new lines are ignored -> why are they not just ignored / replaced?

These warnings are just annoying and serve no real purpose IMO.

SeanPedersen avatar May 07 '25 10:05 SeanPedersen

Because we want to ensure fidelity to user inputs to reduce hidden bugs, modifying user inputs midway may cause user confusion.

Your suggestion is also valid; our logger requires more improvements. Handling newline characters and documentation can be automatically improved.

Plus, longer sentences (over 80 characters) don't always get more accurate—so your advice totally makes sense!

Thank you for your suggestions.

sudoskys avatar May 07 '25 11:05 sudoskys