dashy icon indicating copy to clipboard operation
dashy copied to clipboard

[BUG] Changes saved to local storage not loading properly

Open Lowizer opened this issue 3 years ago • 2 comments
trafficstars

Environment

Self-Hosted (Docker)

System

Firefox 103.0.2, Vivaldi 5.4.2753.47, Docker 20.10.17

Version

2.1.1

Describe the problem

The problem

When creating a new section or item inside the interactive editor and saving to local storage, the section / item disappears after reloading.

Steps to reproduce

  • Open Dashy v.2.1.1 inside any browser
  • Activate the interactive editor
  • Create a new item in any section
  • Save the changes to local storage only
  • Reload the page

Actual Result

confSections seems to be reset to the remote config.

Expected Result

Changes saved to local storage should already be loaded on page load.

Additional info

  • When inspecting the local storage inside the browser, confSections gets updated accordingly after saving the changes made inside the interactive editor.
  • After reloading with the created sections / items missing, when activating the interactive editor again and clicking the Cancel Edit-Button, the items reappear.
  • All InfoHandler-calls are properly output into the console (e.g. New item added or Config has succesfully been saved in browser storage)
  • No warnings or errors are output into the console.
  • The behaviour can also be reproduced in the Demo3, but not in the other two demos with Dashy v.1.9.2.
  • I've taken a peek at the source, but couldn't find the problem. Both initially on page load, als well as clicking the Cancel Edit-Button seem to dispatch the action INITIALIZE_CONFIG, so my guess would be that there's something wrong with either the Vuex.Store, since the ConfigAccumulator also uses its config-states?
  • The appConfig gets saved propely though. Changing the theme or layout survives reloading the page.
  • Is there a probability, that this will also get fixed with #799 ?

Please tick the boxes

Lowizer avatar Sep 09 '22 14:09 Lowizer

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

liss-bot avatar Sep 09 '22 14:09 liss-bot

All the 👀 are turning toward #799, this is where those issues are being fixed.

chevdor avatar Sep 09 '22 15:09 chevdor

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

liss-bot avatar Oct 10 '22 01:10 liss-bot

This issue was automatically closed because it has been stalled for over 6 weeks with no activity.

liss-bot avatar Oct 15 '22 01:10 liss-bot