cl-cookbook icon indicating copy to clipboard operation
cl-cookbook copied to clipboard

Multidimensional array chapter's array-operations does not point to the newest link (the lisp-stat one)

Open Inc0n opened this issue 3 years ago • 8 comments

As the title suggest, also from bendudson/array-operations:

The array-operations library is now maintained by @Symbolics as part of the Lisp-Stat project. The new repository is https://github.com/Lisp-Stat/array-operations.

I think it may not be just simply update the link, as I found there are serveral more demonstration on some of the macros in the package, which points to bendudson/array-operations.

If possible, please advise on whether it should be updated (the link), and how. And I would like to make a PR contribution if possible :)

Inc0n avatar Nov 17 '22 00:11 Inc0n

If you do update the examples, you'll probably want to take them from the array-operations manual.

snunez1 avatar Nov 17 '22 05:11 snunez1

I just had a look at the examples, it seems lisp stat's array operation does not support outer product anymore.

Inc0n avatar Nov 17 '22 10:11 Inc0n

Hmmm. If it supported it before, it should support it now. I didn't remove anything. Do you have an example of the before behaviour? It may also be that it's not documented. Whilst it was living at Ben Dudson's repo the documentation diverged. In fact there's still functionality I haven't documented. The tests have complete coverage though.

snunez1 avatar Nov 17 '22 11:11 snunez1

Sorry, my bad.

  1. I had something going on with a readtable that messed up my testing on repl.
  2. I didn't find #'outer in the documentaiton
  3. Just tested it, It works

Inc0n avatar Nov 17 '22 11:11 Inc0n

Great! Would love an example & documentation for it if you have the time.

snunez1 avatar Nov 17 '22 11:11 snunez1

That would be fairly reasonable task to add to my TODOs. About cl-cookbook tho, I have updated the links pointing to the one by Lisp-stat. The small problem here is I couldn't get jekyll to setup with ruby (Mac M1 machine I got). Would that be ok ... if I submit my PR ...

Inc0n avatar Nov 17 '22 11:11 Inc0n

I am not a committer to cl-cookbook. I just monitor to see what's happening here because I find it a useful resource. Hopefully one of the owners/committers will let you know about the need (or not) for jekyll.

snunez1 avatar Nov 17 '22 13:11 snunez1

Would that be ok ... if I submit my PR ...

It should be OK. The content is markdown so it's easy to review and I can check if necessary.

vindarel avatar Nov 17 '22 15:11 vindarel