Butterfly icon indicating copy to clipboard operation
Butterfly copied to clipboard

implements arrow

Open MrGumpIT opened this issue 1 year ago • 10 comments
trafficstars

add arrow shape add arrow icon add arrow icon in dialog

Can you implement rendering like you did for the triangle?

MrGumpIT avatar May 06 '24 23:05 MrGumpIT

@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 06 '24 23:05 vercel[bot]

Hmm do you think this is a basic shape? I'm more thinking about adding arrows, stars and more as a component in the core pack. It's maybe related to #358

CodeDoctorDE avatar May 07 '24 05:05 CodeDoctorDE

The thing is: I don't want to add more things that we need in the basic shapes. Otherwise it gets very crowded. Maybe we can use this principle: everything that can be detected by the shape detection is a basic shape that we could add.

For an arrow you have the problem that you can have a dotted line, a full sarrow head, a outlined, ... In the basic core pack we can construct an arrow out a line and a triangle

CodeDoctorDE avatar May 07 '24 05:05 CodeDoctorDE

we can do so. Where should I start from to add the basic package?

MrGumpIT avatar May 07 '24 06:05 MrGumpIT

Hmm, I dont like zip/bfly files in this repo. What do you think about making it code driven? A generateCorePack function that adds these things? Currently the pack uses the old json format. Maybe we should readd this format if we dont use the other idea?

CodeDoctorDE avatar May 07 '24 06:05 CodeDoctorDE

where is the actual code so I get an idea of ​​what we're talking about

MrGumpIT avatar May 07 '24 06:05 MrGumpIT

The getCorePack is inside the defaults.dart

CodeDoctorDE avatar May 07 '24 06:05 CodeDoctorDE

what if we simply had SVGs as templates, loaded via json

MrGumpIT avatar May 07 '24 06:05 MrGumpIT

Hmm yeah... SVGs are really cool. We need to look about the license of these to add this. But maybe not really for arrows. If you want to make the line of the arrow longer, you also make the head longer... Hmm that's very tricky

CodeDoctorDE avatar May 07 '24 06:05 CodeDoctorDE

Many sites online offer free svg, but you need to check first

MrGumpIT avatar May 07 '24 07:05 MrGumpIT

i would close this for now... feel free to open another pr if you are done. Maybe we should implement something like a "Anchor" (like in figma) to deal with sizing

CodeDoctorDE avatar May 16 '24 08:05 CodeDoctorDE