Butterfly icon indicating copy to clipboard operation
Butterfly copied to clipboard

[Bug]: performance issue on large single page

Open Luciogi opened this issue 1 year ago • 14 comments
trafficstars

What happened?

A bug happened! when moving around on canvas

Platform Tested: WPA(firefox) Android

File: https://github.com/LinwoodDev/Butterfly/files/15015668/butterfly.bfly.zip

Version

2.1.0-rc.0

Platform

Android

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Luciogi avatar Apr 19 '24 17:04 Luciogi

thanks for reporting, i tested it myself and on firefox it is very buggy, on windows it seems to handle it (maybe because the pc is better than a phone)

CodeDoctorDE avatar Apr 19 '24 17:04 CodeDoctorDE

Umm After comparing Chromium and firefox (on Laptop with power mode on performance) both give nearly same performance when moving around on canvas. From my previous observations I think so my laptop was running on power saving mode

I think that, tools like path eraser and eraser are causing performance issue

Luciogi avatar Apr 19 '24 17:04 Luciogi

Okay thanks. I just wanted to be sure I could reproduce this behavior. I will look at it and try to fix it

CodeDoctorDE avatar Apr 19 '24 17:04 CodeDoctorDE

path eraser tool when delete an element whole visible area is canvas is rerendered. I am also not sure if it refresh objects what are not visible on screen

https://github.com/LinwoodDev/Butterfly/assets/84625092/377dd703-9a3f-4633-837c-87ee82a10409

Luciogi avatar May 07 '24 08:05 Luciogi

Which version do you use currently?

CodeDoctorDE avatar May 07 '24 08:05 CodeDoctorDE

2.1.0-rc.3 just installed latest apk from gitbub actions

Luciogi avatar May 07 '24 08:05 Luciogi

Okay thanks, i will check it

CodeDoctorDE avatar May 07 '24 08:05 CodeDoctorDE

fixed in 2.1.1-rc.1

CodeDoctorDE avatar May 19 '24 18:05 CodeDoctorDE

https://github.com/LinwoodDev/Butterfly/assets/84625092/2d7c34d1-fb4a-4cdc-968d-14ca765e6b6e

  • the easer path pointer is also too slow
  • Erasing path, misses paths , it could be due to slowness of pointer

Luciogi avatar May 20 '24 19:05 Luciogi

thanks for testing, I will try to improve this a bit

CodeDoctorDE avatar May 20 '24 19:05 CodeDoctorDE