Butterfly icon indicating copy to clipboard operation
Butterfly copied to clipboard

Published 20 hours ago • verified publisher icon LinwoodDev

[Bug]: Flatpak install says "nightly" when I install latest stable

Open markwmuller opened this issue 1 year ago • 5 comments
trafficstars

What happened?

Installing Butterfly via flatpak (https://flathub.org/apps/dev.linwood.butterfly) gives me version 2.0.0, but the banner at the top says "Butterfly Nightly". I'm guessing there's a mixup somewhere.

image

image

I'm using Ubuntu 22.04.

Version

2.0.0

Platform

Linux

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

markwmuller avatar Jan 15 '24 00:01 markwmuller

Thanks for reporting. The bug shouldn't be too critical, with the nightly version you can try out the collaboration feature

CodeDoctorDE avatar Jan 15 '24 08:01 CodeDoctorDE

Fixed in 2.0.1

CodeDoctorDE avatar Jan 15 '24 08:01 CodeDoctorDE

Reopened because it didn't fix the problem

CodeDoctorDE avatar Jan 15 '24 09:01 CodeDoctorDE

Can confirm, just installed butterfly flatpak and also got the nightly

derkrasseleo avatar Jan 15 '24 15:01 derkrasseleo

Yeah, the problem is: The check for nightly is wrong: https://github.com/LinwoodDev/Butterfly/blob/da8ed04432b84810dcc0eb9b63023ffb79c8aad1/.github/workflows/build.yml#L160

The github.event_name is "push" and we don't get the information if the running job is inside a prerelease or not

CodeDoctorDE avatar Feb 01 '24 11:02 CodeDoctorDE