api-testing icon indicating copy to clipboard operation
api-testing copied to clipboard

Error occur from `retest` GitHub Actions

Open LinuxSuRen opened this issue 1 year ago • 14 comments

Description:

What issue is being seen? Describe what should be happening instead of the bug, for example: api-testing should not crash, the expected value isn't returned, etc.

Repro steps:

Include sample requests, environment, etc. All data and inputs required to reproduce the bug.

Note: If there are privacy concerns, sanitize the data prior to sharing.

Environment:

Include the environment like api-testing version, os version and so on.

Logs:

Include the access logs and the api-testing logs.

image

LinuxSuRen avatar Apr 26 '24 08:04 LinuxSuRen

hi @yuluo-yx Please help to take a look at this error.

LinuxSuRen avatar Apr 26 '24 08:04 LinuxSuRen

It looks like every comment will trigger it.

image

LinuxSuRen avatar Apr 26 '24 08:04 LinuxSuRen

I just reverted it. We can add it once you fixed it.

LinuxSuRen avatar Apr 26 '24 08:04 LinuxSuRen

Maybe the version should be lowercase yuluo-yx/[email protected] https://github.com/LinuxSuRen/api-testing/blob/42c4eb259beef22488085d7c728f7f71c333c71b/.github/workflows/command.yml#L23

Ink-33 avatar Apr 26 '24 08:04 Ink-33

sorry, is my question, It version is v1.0.0-RC1, I write was V1.0.0-RC1 😢😢

yuluo-yx avatar Apr 26 '24 08:04 yuluo-yx

But why it is triggered no matter what comment is created. I think we need to add a filter. It can be triggered only the specific comment created.

LinuxSuRen avatar Apr 26 '24 08:04 LinuxSuRen

But why it is triggered no matter what comment is created. I think we need to add a filter. It can be triggered only the specific comment created.

The current logic is to get the comment content and run the failed task if it is /retest.

I'll implement his. 🤔

yuluo-yx avatar Apr 26 '24 08:04 yuluo-yx

I'm not sure if GitHub Actions support that kind of filter.

LinuxSuRen avatar Apr 26 '24 08:04 LinuxSuRen

I'm not sure if GitHub Actions support that kind of filter.

Let me see the documentation and study it

yuluo-yx avatar Apr 26 '24 08:04 yuluo-yx

@LinuxSuRen I study envoy repo command.yml. I've found that I have to run a workflows anyway, and github doesn't have a hook for that.

For more information you can refer to this comment, it's not /retest but judging from the action logs, it's still executing it, but not the retest action

action: https://github.com/envoyproxy/envoy/actions/runs/8845882918/job/24290669995 comment: https://github.com/envoyproxy/envoy/pull/33818#issuecomment-2078967461

yuluo-yx avatar Apr 26 '24 09:04 yuluo-yx

I'm afraid too many triggers will burn out the GitHub Actions minutes. See also the official document.

2,000 minutes per month

LinuxSuRen avatar Apr 26 '24 09:04 LinuxSuRen

I'm afraid too many triggers will burn out the GitHub Actions minutes. See also the official document.

2,000 minutes per month

got it, It's a factor that really needs to be taken into account 🤔

yuluo-yx avatar Apr 26 '24 10:04 yuluo-yx

By the way, you can make it be a webook server. And I know a free service that can deploy it. See https://zeabur.com/pricing

LinuxSuRen avatar Apr 27 '24 10:04 LinuxSuRen

By the way, you can make it be a webook server. And I know a free service that can deploy it. See https://zeabur.com/pricing

tks, let me study

yuluo-yx avatar Apr 28 '24 12:04 yuluo-yx