Thorsten Lünborg

Results 351 comments of Thorsten Lünborg
trafficstars

This is not by accident. it's a compromise to get better performance when using an iterator. Your proposed change would introduce a bug where a `map.set()` operation will no longer...

I think we think in the same direction. I understood your initial description to argue for a simple removal of the `ITERATE_KEY` on set. Not sure as of now if...

All vnodes should have a `type` property, it's a mandatory field. So I'm worried that simply "working around" a case where a vnode has an undefined type, might mask the...

This reproduction isn't runnable or minimal - it uses stripe api, which fails for a missing API key, and fails with errors when trying to follow step 1 of the...

> > @talhameer could you please remove/work around the dependency on stripe? > > I've removed the extra code around Stripe. Please check [here](https://stackblitz.com/edit/vitejs-vite-48q3zs?file=src%2Fviews%2FCartView.vue) The demo is still unusable because...

Not sure where to check. the last link still has no API key.

Please open a new issue if you manage to create a runnable reproduction that doesn't involve vue-stripe or the stripe API.

I agree with your comments and will adjust the PR accordingly

Closing as a reproduction still hasn't been provided