LinasKo
LinasKo
Hey @onuralpszr, I'm adding you as an optional reviewer. Feel free to have a look if you have the time and motivation.
### Contribution guidelines If you would like to make a contribution, please check that no one else is assigned already. Then leave a comment such as "Hi, I would like...
Hi @Kadermiyanyedi :wave: Thanks for letting me know! Feel free to take your time. Your submissions are always of a very high quality so I'm happy either way, even if...
Hi @Kadermiyanyedi, Quick note, there's been a few updates on the tracker today: * I merged #1528, which changes the behaviour when more than one `ByteTrack` is used simultaneously. *...
Another update: It may be possible to just remove `class_ids` from `STracks` entirely. I didn't see it being used anywhere, nor does it appear in the [original ByteTrack](https://github.com/ifzhang/ByteTrack/blob/main/yolox/tracker/byte_tracker.py) implementation.
I recall seeing `-1` as a special temporary value somewhere. Are detections also gone when you use `-2`, or some large positive integer?
Thank you @Kadermiyanyedi! I'm away at the moment and will be back around next Wednesday; I'll review it then. Thank you for your contribution!
This is now completed. Thanks @Kadermiyanyedi!
Hey @hardikdava, I took a deeper look. I know I asked for the PR, and it solves your problem, but we need time to think. Most importantly, if we just...
The dosctring is misplaced, does not follow our other documentation style and attempts to document a function we perceive as private (admittedly it's not very transparent which ones are -...