ReactRenderer icon indicating copy to clipboard operation
ReactRenderer copied to clipboard

Fail loud should apply consistently

Open rakelley opened this issue 6 years ago • 1 comments

As we understand it, the intent behind fail_loud is to allow graceful degradation to client-side-only rendering in production if SSR fails. The current implementation currently only supports this for errors returned by the JS rendering implementation, rather than generated by the PHP renderer itself. This PR changes fail_loud: false to universally prevent SSR-originating errors from preventing page rendering. If this is not a desired change, an alternative would be to add a separate option to control this behavior.

This change required bumping the minimum PHP version to permit \Throwable, I hope this is acceptable as at this point such versions are long past EOL.

rakelley avatar Feb 26 '19 21:02 rakelley

I fixed the test and config to pass CI on 7.1 - 7.3, it doesn't appear the 8.0 nightly is a compatible target and should likely be dropped.

rakelley avatar Feb 27 '19 14:02 rakelley