lightning-flash icon indicating copy to clipboard operation
lightning-flash copied to clipboard

CI: Update docker image

Open akihironitta opened this issue 3 years ago • 2 comments
trafficstars

What does this PR do?

  • Part of https://github.com/Lightning-AI/lightning/pull/13831.
  • Updates PyTorch version from 1.8 to 1.9 as we don't build 1.8 images in the PL repo anymore. (Let's see if the CI allows it...)

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • [x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

akihironitta avatar Aug 05 '22 06:08 akihironitta

Codecov Report

Merging #1411 (e7561a7) into master (2657315) will decrease coverage by 0.79%. The diff coverage is n/a.

:exclamation: Current head e7561a7 differs from pull request most recent head e59188d. Consider uploading reports for the commit e59188d to get more accurate results

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
- Coverage   91.79%   91.00%   -0.80%     
==========================================
  Files         286      286              
  Lines       12861    12861              
==========================================
- Hits        11806    11704     -102     
- Misses       1055     1157     +102     
Flag Coverage Δ
unittests 91.00% <ø> (-0.80%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/graph/classification/input.py 45.45% <0.00%> (-54.55%) :arrow_down:
flash/graph/classification/cli.py 38.46% <0.00%> (-53.85%) :arrow_down:
flash/graph/collate.py 50.00% <0.00%> (-50.00%) :arrow_down:
flash/graph/classification/model.py 42.62% <0.00%> (-49.19%) :arrow_down:
flash/graph/embedding/model.py 54.83% <0.00%> (-45.17%) :arrow_down:
flash/graph/backbones.py 64.28% <0.00%> (-35.72%) :arrow_down:
flash/graph/classification/input_transform.py 66.66% <0.00%> (-33.34%) :arrow_down:
flash/graph/classification/data.py 69.23% <0.00%> (-30.77%) :arrow_down:
flash/core/data/utilities/samples.py 87.50% <0.00%> (-12.50%) :arrow_down:
flash/text/question_answering/collate.py 95.29% <0.00%> (-4.71%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 06:08 codecov[bot]

Please don't worry about the failures, the CI is failing, and I'm working on it: #1410. :)

krshrimali avatar Aug 05 '22 06:08 krshrimali

A couple of examples failures, namely: Lightning-AI.lightning-flash (Examples) (domain text with GPUs 0) and Lightning-AI.lightning-flash (Examples) (domain video with GPUs 0,1) are flaky. The text example is failing with some connection error to HuggingFace.co and the video example is failing with CUDA Runtime Error, I'll be re-running these tests to ensure they pass, and then we can merge this. (Other failures are being fixed, should be good very soon)

krshrimali avatar Aug 13 '22 03:08 krshrimali

@krshrimali Thank you, Kush, for having a look at this! I'll re-re-run these three failing jobs and see if they pass this time :)

Lightning-AI.lightning-flash (Examples) Required
Lightning-AI.lightning-flash (Examples) (domain video with GPUs 0,1)
Lightning-AI.lightning-flash (Special)

akihironitta avatar Aug 15 '22 11:08 akihironitta