lightning-flash icon indicating copy to clipboard operation
lightning-flash copied to clipboard

Move notebooks to Lightning Tutorials

Open krshrimali opened this issue 3 years ago • 2 comments

What does this PR do?

Addresses #10 - We are moving notebooks from lightning-flash to lightning/tutorials repository. The merge is happening here.

Before submitting

  • [ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes?
  • [ ] Did you write any new necessary tests? [not needed for typos/docs]
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • [ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

krshrimali avatar Jul 28 '22 07:07 krshrimali

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Codecov Report

Merging #1405 (baa116e) into master (6859fa1) will decrease coverage by 25.49%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1405       +/-   ##
===========================================
- Coverage   92.91%   67.42%   -25.50%     
===========================================
  Files         286      286               
  Lines       12861    12858        -3     
===========================================
- Hits        11950     8669     -3281     
- Misses        911     4189     +3278     
Flag Coverage Δ
unittests 67.42% <ø> (-25.50%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/serve/dag/order.py 5.62% <0.00%> (-90.78%) :arrow_down:
flash/core/serve/dag/optimization.py 6.86% <0.00%> (-86.92%) :arrow_down:
...lash/image/embedding/vissl/transforms/utilities.py 15.15% <0.00%> (-84.85%) :arrow_down:
flash/core/serve/dag/visualize.py 19.04% <0.00%> (-76.20%) :arrow_down:
flash/core/serve/dag/utils.py 19.29% <0.00%> (-75.44%) :arrow_down:
flash/core/serve/component.py 21.69% <0.00%> (-72.65%) :arrow_down:
flash/core/integrations/icevision/transforms.py 20.23% <0.00%> (-72.03%) :arrow_down:
flash/core/integrations/labelstudio/visualizer.py 24.00% <0.00%> (-72.00%) :arrow_down:
flash/core/serve/utils.py 28.57% <0.00%> (-71.43%) :arrow_down:
flash/core/serve/dag/task.py 31.21% <0.00%> (-66.67%) :arrow_down:
... and 134 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 28 '22 07:07 codecov[bot]