lightning-flash icon indicating copy to clipboard operation
lightning-flash copied to clipboard

Improve code coverage for `flash.core.data.utilities.paths`

Open jxtngx opened this issue 3 years ago • 6 comments

What does this PR do?

Improves code coverage for flash.core.data.utilities.paths

Fixes #1391

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [x] Did you make sure to update the documentation with your changes?
  • [x] Did you write any new necessary tests? [not needed for typos/docs]
  • [x] Did you verify new and existing tests pass locally with your changes?
  • [x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • [x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

jxtngx avatar Jul 14 '22 18:07 jxtngx

Codecov Report

Merging #1393 (2e409dd) into master (3644211) will decrease coverage by 33.48%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #1393       +/-   ##
===========================================
- Coverage   92.90%   59.41%   -33.49%     
===========================================
  Files         286      286               
  Lines       12861    12863        +2     
===========================================
- Hits        11948     7643     -4305     
- Misses        913     5220     +4307     
Flag Coverage Δ
unittests 59.41% <100.00%> (-33.49%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/utilities/paths.py 98.55% <100.00%> (+6.01%) :arrow_up:
flash/core/serve/dag/order.py 5.60% <0.00%> (-90.81%) :arrow_down:
flash/core/serve/dag/optimization.py 6.84% <0.00%> (-86.93%) :arrow_down:
...lash/image/embedding/vissl/transforms/utilities.py 15.15% <0.00%> (-84.85%) :arrow_down:
flash/core/serve/dag/visualize.py 19.04% <0.00%> (-76.20%) :arrow_down:
flash/core/serve/dag/utils.py 19.29% <0.00%> (-75.44%) :arrow_down:
flash/core/serve/component.py 21.69% <0.00%> (-72.65%) :arrow_down:
flash/core/integrations/icevision/transforms.py 20.23% <0.00%> (-72.03%) :arrow_down:
flash/core/integrations/labelstudio/visualizer.py 24.00% <0.00%> (-72.00%) :arrow_down:
flash/core/serve/utils.py 28.57% <0.00%> (-71.43%) :arrow_down:
... and 186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 14 '22 18:07 codecov[bot]

Hey, @JustinGoheen - Any updates on this?

krshrimali avatar Jul 28 '22 06:07 krshrimali

@krshrimali I am working several other PRs for Lightning, and have this slated for next week

https://github.com/users/JustinGoheen/projects/16/views/3

jxtngx avatar Jul 28 '22 09:07 jxtngx

@krshrimali can you please let me know if this submission looks good, or if anything needs to be be changed

jxtngx avatar Aug 09 '22 15:08 jxtngx

Hi, @JustinGoheen - I apologize for the delay. The Flash CI is down with around 14 reasonable failures, and I've prioritized it for this week - trying to get it done as soon as possible. Once done, it will allow me to come back to the amazing work you and other contributors have done in these PRs - and help merge them once they look good.

Unfortunately, I believe I'll be able to get back to this either by the end of this week or by the start of the next week. ❤️ I hope that's fine with you. Thank you again for your work!

Edit: Also, in case there are any major changes, and if you are occupied, I'll be happy to update this PR to help land this PR. :))

krshrimali avatar Aug 09 '22 15:08 krshrimali

sounds good to me. thank you for the quick update.

jxtngx avatar Aug 09 '22 15:08 jxtngx

Hey, unfortunately the fork is deleted, so we'll be unable to fix the failures and merge it. Thank you for your interest though, we appreciate that. :)

krshrimali avatar Sep 01 '22 12:09 krshrimali