lightning-flash icon indicating copy to clipboard operation
lightning-flash copied to clipboard

Move notebooks to lightning-tutorials

Open Borda opened this issue 4 years ago • 7 comments

🚀 Feature

better and faster testing of attached notebooks

Motivation

Pitch

Alternatives

Additional context

https://blog.kovalevskyi.com/continues-integration-for-your-jupyter-notebooks-on-github-with-gcp-f72af5b08bcd

Borda avatar Jan 29 '21 10:01 Borda

What do you test here, success or previous cached results ?

edgarriba avatar Apr 10 '21 07:04 edgarriba

What do you test here, success or previous cached results ?

we shall test the execution...

Borda avatar Apr 10 '21 08:04 Borda

In kornia I'm using https://myst-nb.readthedocs.io that runs every time the notebook every time we build docs

edgarriba avatar Apr 10 '21 08:04 edgarriba

As another option, we could use --nbval which is an extension of pytest to test notebook cells. https://github.com/computationalmodelling/nbval

akihironitta avatar May 14 '21 17:05 akihironitta

As another option, we could use --nbval which is an extension of pytest to test notebook cells. https://github.com/computationalmodelling/nbval

Very nice, is it something new?

Borda avatar May 14 '21 18:05 Borda

Seems It has existed for years like since around 2015 :]

akihironitta avatar May 23 '21 03:05 akihironitta

@ethanwharris let's move all notebooks here: https://github.com/PyTorchLightning/lightning-tutorials

Borda avatar Nov 18 '21 13:11 Borda