tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

Initial tabular classification Santander

Open PabloAMC opened this issue 3 years ago • 4 comments
trafficstars

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you make sure to update the docs?
  • [x] Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

PabloAMC avatar Dec 13 '21 21:12 PabloAMC

hi, seems you are accidentally changing some other files in Flash turorials

I changed the name of the electricity_forecasting folder to tabular_forecasting. I believe that might be much more informative.

PabloAMC avatar Dec 21 '21 12:12 PabloAMC

Why do we get error

python -m pytest flash_tutorials/tabular_classification/santander.ipynb -v --nbval
deactivate
rm -rf flash_tutorials/tabular_classification/venv
401 - Unauthorized
Error: Process completed with exit code 1.

?

PabloAMC avatar Dec 30 '21 14:12 PabloAMC

@PabloAMC seems like some variables in the notebook are not defined... mind checking the failing test?

Borda avatar Mar 09 '22 19:03 Borda

Codecov Report

Merging #124 (e9d886a) into main (89b94ba) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #124   +/-   ##
===================================
  Coverage    73%    73%           
===================================
  Files         2      2           
  Lines       382    382           
===================================
  Hits        280    280           
  Misses      102    102           

codecov[bot] avatar Apr 27 '22 09:04 codecov[bot]