torchmetrics icon indicating copy to clipboard operation
torchmetrics copied to clipboard

Refactor/classification 8

Open SkafteNicki opened this issue 3 years ago • 1 comments

What does this PR do?

Continues work on classification refactor https://github.com/Lightning-AI/metrics/issues/1001 Prior work:

  • https://github.com/Lightning-AI/metrics/pull/1167
  • https://github.com/Lightning-AI/metrics/pull/1163
  • https://github.com/Lightning-AI/metrics/pull/1159
  • https://github.com/Lightning-AI/metrics/pull/1151
  • https://github.com/Lightning-AI/metrics/pull/1145
  • https://github.com/Lightning-AI/metrics/pull/1143
  • https://github.com/Lightning-AI/metrics/pull/1054

This PR takes care of calibration_errror and hinge_loss which are the final two metrics that need to be reformatted.

Before submitting

  • [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure to update the docs?
  • [x] Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

SkafteNicki avatar Aug 05 '22 12:08 SkafteNicki

Codecov Report

Merging #1175 (b77df12) into devel/classification (3c0d55a) will decrease coverage by 37%. The diff coverage is 91%.

@@                  Coverage Diff                   @@
##           devel/classification   #1175     +/-   ##
======================================================
- Coverage                    90%     52%    -37%     
======================================================
  Files                       189     189             
  Lines                     10543   10767    +224     
======================================================
- Hits                       9469    5648   -3821     
- Misses                     1074    5119   +4045     

codecov[bot] avatar Aug 17 '22 15:08 codecov[bot]