pytorch-lightning
pytorch-lightning copied to clipboard
Fix wrong pad num in rich progress bar
What does this PR do?
Fixes #12113
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
- [x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
- [x] Did you read the contributor guideline, Pull Request section?
- [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
- [x] Did you make sure to update the documentation with your changes? (if necessary)
- [x] Did you write any new necessary tests? (not for typos and docs)
- [x] Did you verify new and existing tests pass locally with your changes?
- [x] Did you list all the breaking changes introduced by this pull request?
- [x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
PR review
Anyone in the community is welcome to review the PR. Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
- [x] Is this pull request ready for review? (if not, please submit in draft mode)
- [x] Check that all items from Before submitting are resolved
- [x] Make sure the title is self-explanatory and the description concisely explains the PR
- [x] Add labels and milestones (and optionally projects) to the PR so it can be classified
Did you have fun?
Make sure you had fun coding 🙃
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.
This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.
Can you also update the CHANGELOG and add a test for this?
Codecov Report
Merging #12125 (861b14f) into master (9722127) will increase coverage by
15%. The diff coverage is100%.
:exclamation: Current head 861b14f differs from pull request most recent head 984e14d. Consider uploading reports for the commit 984e14d to get more accurate results
@@ Coverage Diff @@
## master #12125 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 324 324
Lines 26369 26739 +370
=========================================
+ Hits 16138 20438 +4300
+ Misses 10231 6301 -3930
@Borda Seems like I can't resolve the conflicts as https://github.com/shenmishajing/pytorch-lightning.git doesn't exist.
Do you know a solution for this?
@kaushikb11 I suggest copying the patch into a branch of your own and opening a new PR that closes this one