LibreCat icon indicating copy to clipboard operation
LibreCat copied to clipboard

citation-block-link should be block link; no absolute position!

Open nicolasfranck opened this issue 3 years ago • 3 comments

Fixes #940

DONE:

  • citation-block-link is no longer an absolute positioned link (without content) that hovers above the rest (including the title). It is just a link with display:block. This way the href applies to the block, instead of only the text (so same effect, but cleaner). Had to regenerate the main.css. Keep in mind to clear your browser cache (which is another issue: the name of the main.css)
  • removed onclick statements

nicolasfranck avatar Jun 14 '22 09:06 nicolasfranck

I can't seem to reproduce the error with the link. Can you show screenshots of what happens? Or explain in more detail which div covers which link?

petrakohorst avatar Jun 15 '22 10:06 petrakohorst

The citation-block-div, which is a link with an empty body is hovering over the entire record block in the list view (because of width, height and position in css), including the title of the record, that also has a link (same link!), but which cannot be clicked. It is hard to see the difference though, but I removed the dependency on javascript (onclick). Now both the record link and the citation can be clicked separately.

I just removes unneeded complicated code.

nicolasfranck avatar Jun 15 '22 10:06 nicolasfranck

I only seems to happen in routes like /librecat/search/admin.

Screenshot 2022-06-15 at 15 10 40

nicolasfranck avatar Jun 15 '22 13:06 nicolasfranck