LibreCAD icon indicating copy to clipboard operation
LibreCAD copied to clipboard

Add new glyphs to the vectorfont from Solvespace

Open phkahler opened this issue 4 years ago • 2 comments

Solvespace uses the vector font from LibreCAD and has had some character added since then: https://github.com/solvespace/solvespace/issues/1042#issuecomment-844820653

Some Ukrainian characters as well as the Depth, Counterbore, and Countersink commonly used to annotate holes.

I can make PR to merge these into the current LibreCAD font file, or we could go the other way and merge LibreCAD changes into solvespace and give them back. It seems like a good idea to share these updates between projects. If we get back in sync I'll try to remember to submit changes to both if/when they happen again.

phkahler avatar May 20 '21 19:05 phkahler

JFTR, I'm an author of those "Some Ukrainian characters" (i.e.Ґ, ґ, І, і, Ї, і, Є, є), which are already merged in LibreCAD (and then was merged to SolveSpace too!):

  • https://github.com/LibreCAD/LibreCAD/issues/690

    @Evil-Spirit later found small issue with some of those characters (e.g. `є` and `Ї`):
    • https://github.com/LibreCAD/LibreCAD/commit/ca6f39feb916390596c7ed3a0cfd88e935cd4e74#commitcomment-17007934
    • https://github.com/LibreCAD/LibreCAD/commit/ca6f39feb916390596c7ed3a0cfd88e935cd4e74#commitcomment-17007980

    And there was an additional patch applied to є charater in SolveSpace:

    • https://github.com/solvespace/solvespace/commit/9c08398f51d5040245001c53ccd8388107221216#diff-e99cc430914390ed01b41b9eeefd419ec4c099e6b15d4fd5b29612e21cb8cfa0
  • UPD: Just fixed Ukrainian letters in LibreCAD's unicode.lff and pulled it for LibreCAD (SolveSpace probably already has fixed those characters):

    • https://github.com/LibreCAD/LibreCAD/pull/1350

as well as the Depth, Counterbore, and Countersink commonly used to annotate holes

I may take a look on pulling those special characters into LibreCAD's unicode.lff, and then it could be merged into SolveSpace's repo from LibreCAD's repo for continuous integration.

ghost avatar May 20 '21 19:05 ghost

@dxli This issue could be closed as solved.

u2fly avatar Aug 31 '24 20:08 u2fly