libvncserver icon indicating copy to clipboard operation
libvncserver copied to clipboard

libvncserver: handle EINTR

Open piec opened this issue 4 years ago • 4 comments
trafficstars

Hi,

I'm using libvncserver in a program that uses many signals, I have no control over that. I noticed that this select sometimes gets an EINTR.

The proposed fix is not pretty because it uses a goto but it's also simple & readable. Please tell me if you'd prefer a do {} while loop. The disadvantage is that the break after would have to changed.

Thanks for this awesome lib Pierre

PS: I suspect other syscalls could have issues too

piec avatar Sep 27 '21 16:09 piec

I don't remember if I've tried it, I'll have to check again

piec avatar Apr 11 '22 20:04 piec

I don't remember if I've tried it, I'll have to check again

That'd be nice - thank's in advance!

bk138 avatar Apr 11 '22 21:04 bk138

Needs a check if continue does the job as well.

bk138 avatar Apr 28 '22 14:04 bk138

I'll get some time to look at it at the beginning of next week

piec avatar Apr 28 '22 15:04 piec