DungeonTools icon indicating copy to clipboard operation
DungeonTools copied to clipboard

Feat: Add Linter. Cleanup Files

Open Sinaloit opened this issue 4 years ago • 0 comments

  • [x] Added Super-Linter action

  • Will fail if errors found now that all known base issues are resolved.

  • Symlink in root for local usage

  • Ignores Libs from other sources

  • Ignores error 212 unused function arguments (reasoning: module:function passes self but if self is never used this warns)

  • Ignoring error code 432: ignore shadowing upvalue argument

  • [x] Formatted all lua files w/ 4 spaces.

  • [x] Resolve luacheck errors in dungeon files

  • POI overlaps in Karazahn Lower & Upper, initial element commented out, can re-number but not sure if accurate.

  • Resolved POI overlap in Mists with assistance of @CalistusK

  • [x] Resolve luacheck errors in base files

  • First pass at resolving the errors.

Sinaloit avatar Jan 08 '21 20:01 Sinaloit