table-sort-js icon indicating copy to clipboard operation
table-sort-js copied to clipboard

Table arrows do not disappear

Open ccapndave opened this issue 1 year ago • 3 comments

If I enable table-arrows, clicking on column 1 shows an arrow as expected. However, clicking on column 2 shows the arrow for column 2 and column 1. I think that only one arrow should be visible at a time.

ccapndave avatar Nov 28 '24 14:11 ccapndave

@ccapndave which version is this? I did changes in the latest release for custom table arrows, so it might be a regression. Can you compare v1.21.0 to v1.22.1 ;I don't remember exactly what the behaviour was... 🛌🏻

kyle-wannacott avatar Nov 28 '24 15:11 kyle-wannacott

Thanks for the quick response! This is on 1.22.1. I checked on 1.12.0 and the behaviour is the same.

ccapndave avatar Nov 28 '24 15:11 ccapndave

@ccapndave I don't think the table arrows should disappear?, however if clicking on another column it should reset all table arrows to the neutral arrow before setting the arrow up/down on the column being sorted (I'm guessing this is what you want???); however, the current implementation should still apply when the "remember-sort" tag is applied (not that anybody probably uses this tag...).

kyle-wannacott avatar Nov 29 '24 00:11 kyle-wannacott